fix(client/cordova/apple/macos): fix popover click and location issues #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of assuming responsibility for closing the popover in the app.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sbruens/server-list-lit #1845 +/- ##
=======================================================
Coverage 32% 32%
=======================================================
Files 45 45
Lines 2610 2610
Branches 337 337
=======================================================
Hits 859 859
Misses 1751 1751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fortuna
approved these changes
Feb 21, 2024
daniellacosse
approved these changes
Feb 21, 2024
|
Any idea why the iOS build is failing? It seems the other PR is failing too. |
I think they all are. Some third party thing must have broken? |
sbruens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes the following popover issues on macos:
This should allow us to release a fixed old macos client while we try to resolve the VpnExtension's gomobile issues for Catalyst on arm64.